- fixed - IedConnection_setRCBValuesAsync crashes when RCB is already…

… reserved by other client (LIB61850-382)
mz-automation · Jan 20, 2023 · 8dae8c1 · 8dae8c1
1 parent 9b977e2
commit 8dae8c1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/iec61850/client/client_report_control.c b/src/iec61850/client/client_report_control.c
@@ -808,8 +808,9 @@ writeVariableHandler(uint32_t invokeId, void* parameter, MmsError mmsError, MmsD
             handler(param->originalInvokeId, call->callbackParameter, err);
 
             releaseWriteCall(self, call, param);
-        }
 
+            goto exit_function;
+        }
 
         param->currentItemId = LinkedList_getNext(param->currentItemId);
 
@@ -829,6 +830,7 @@ writeVariableHandler(uint32_t invokeId, void* parameter, MmsError mmsError, MmsD
             MmsConnection_writeVariableAsync(self->connection, &(call->invokeId), &writeError, param->domainId, itemId, value, writeVariableHandler, self);
 
             if (writeError != MMS_ERROR_NONE) {
+
                 handler(param->originalInvokeId, call->callbackParameter, iedConnection_mapMmsErrorToIedError(writeError));
 
                 releaseWriteCall(self, call, param);
@@ -839,6 +841,10 @@ writeVariableHandler(uint32_t invokeId, void* parameter, MmsError mmsError, MmsD
         if (DEBUG_IED_CLIENT)
             printf("IED_CLIENT: internal error - no matching outstanding call!\n");
     }
+
+exit_function:
+
+    return;
 }
 
 uint32_t

diff --git a/src/iec61850/client/ied_connection.c b/src/iec61850/client/ied_connection.c
@@ -105,6 +105,9 @@ iedConnection_mapMmsErrorToIedError(MmsError mmsError)
     case MMS_ERROR_DEFINITION_OBJECT_UNDEFINED:
         return IED_ERROR_OBJECT_UNDEFINED;
 
+    case MMS_ERROR_ACCESS_TEMPORARILY_UNAVAILABLE:
+        return IED_ERROR_TEMPORARILY_UNAVAILABLE;
+
     default:
         return IED_ERROR_UNKNOWN;
     }