-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makes npm targets work on Windows #13
Conversation
I am having a problem running the test script as well on windows. If I remove the single quotes around the target regex, it works like this:
I will submit a separate PR for that. |
@@ -3,10 +3,10 @@ | |||
"version": "0.0.0", | |||
"description": "Universal Redux Template", | |||
"scripts": { | |||
"start": "NODE_PATH=./app nodemon app/server & node webpack.server.js & gulp css:watch", | |||
"test": "NODE_ENV=test NODE_PATH=./app mocha --compilers js:babel-register -r app/spec/support/setup.mocha.js --recursive 'app/spec/**/*.test.js' -w", | |||
"start": "cross-env NODE_PATH=./app concurrent --kill-others \"nodemon app/server\" \"node webpack.server.js\" \"npm run css:watch\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS job doesn't run since there's no npm script named css:watch
. It should be gulp css:watch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I totally missed that one
@jbuffin Thanks a lot! I left some comments on the commits. Also, could you please update |
@mz026 is there anything else you need on this? |
@jbuffin for the |
@jbuffin any update on this? |
Yes sorry, I got busy yesterday and didn't get a chance to rerun shrinkwrap with |
no problem! thanks a lot! 👍 |
# Conflicts: # package.json
@mz026 I had to update one of the packages in order to get shrinkwrap to run correctly. All should be good now. |
@jbuffin thanks!! |
cross-env
&
works differently on windows so useconcurrently
insteadrm -rf
is Unix only so userimraf
library