Fixed a subtle ordering bug.

mzarra · Aug 31, 2012 · e6ceb94 · e6ceb94
1 parent c1e5da6
commit e6ceb94
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/UIImageView+ZSAssetManagerAdditions.m b/UIImageView+ZSAssetManagerAdditions.m
@@ -16,14 +16,14 @@ @implementation UIImageView (ZSAssetManagerAdditions)
 
 - (void)setImageWithURL:(NSURL *)url
 {
+  objc_setAssociatedObject(self, assetManagerImageURLKey, url, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
+  self.image = nil;
+
   if (!url) {
     DLog(@"nil url passed");
-    objc_removeAssociatedObjects(self);
     return;
   }
 
-  objc_setAssociatedObject(self, assetManagerImageURLKey, url, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
-
   __weak UIImageView *blockSelf = self;
   [[ZSAssetManager sharedAssetManager] fetchImageForURL:url withCompletionBlock:^(NSURL *fetchedUrl, UIImage *image) {
 
@@ -37,8 +37,13 @@ - (void)setImageWithURL:(NSURL *)url
 
 - (void)setImageWithURL:(NSURL *)url placeholderImage:(UIImage *)placeholderImage
 {
-  self.image = placeholderImage;
+  // Request the image from the asset manager.
   [self setImageWithURL:url];
+
+  // If the asset manager has it, don't set the placeholder.
+  if (!self.image) {
+    self.image = placeholderImage;
+  }
 }
 
 @end