Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests package needed but not added as dependency #27

Closed
sasa-buklijas opened this issue Oct 11, 2023 · 5 comments
Closed

requests package needed but not added as dependency #27

sasa-buklijas opened this issue Oct 11, 2023 · 5 comments

Comments

@sasa-buklijas
Copy link
Contributor

$ pyubee -h
Traceback (most recent call last):
  File "/.../9_no_git_testing/pyubee/venv-3_12_0/bin/pyubee", line 5, in <module>
    from pyubee.__main__ import main
  File "/.../9_no_git_testing/pyubee/venv-3_12_0/lib/python3.12/site-packages/pyubee/__init__.py", line 8, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

requests package needed but not added as dependency.
Could do it, but do not know what version to set.

@mzdrale
Copy link
Owner

mzdrale commented Oct 12, 2023

Thanks @sasa-buklijas for creating issue.

If you have time, please add it and create PR. I would use the latest requests==2.31.0.
Thanks.

@sasa-buklijas
Copy link
Contributor Author

do you want as requests==2.31.0 or requests>=2.31.0 ?

@mzdrale
Copy link
Owner

mzdrale commented Oct 13, 2023

I would pin it to the specific version, so requests==2.31.0. Thanks for contributing. :)

@sasa-buklijas
Copy link
Contributor Author

done #30

@mzdrale
Copy link
Owner

mzdrale commented Oct 16, 2023

Thank you. Changes merged and new 0.13 version released.

@mzdrale mzdrale closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants