Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support first party plugins and loaders #72

Open
14 of 43 tasks
mzgoddard opened this issue Dec 8, 2016 · 5 comments
Open
14 of 43 tasks

Support first party plugins and loaders #72

mzgoddard opened this issue Dec 8, 2016 · 5 comments

Comments

@mzgoddard
Copy link
Owner

mzgoddard commented Dec 8, 2016

Support all plugins and loaders under https://github.com/webpack. Support can be not caching but making sure builds are correct and complete or fail as expected.

  • * Resolution to this module is cached (in addition to modules depending on this being cached)
  • ** Modules depending on this are cached

Under https://github.com/webpack/webpack

Under https://github.com/webpack-contrib

  • extract-text-webpack-plugin *
  • mini-css-extract-plugin
  • style-loader
  • css-loader
  • mocha-loader
  • null-loader
  • imports-loader
  • json-loader
  • url-loader
  • file-loader
  • raw-loader
  • less-loader
  • exports-loader
  • html-loader
  • coffee-loader
  • expose-loader
  • json5-loader
  • transform-loader
  • coffee-redux-loader
  • bundle-loader
  • script-loader
  • jshint-loader
  • i18n-webpack-plugin
  • compression-webpack-plugin
  • coverjs-loader
  • multi-loader
  • i18n-loader
  • source-map-loader
  • worker-loader
@aaronjensen
Copy link

Ah, I was planning on opening an issue to say that CommonsChunkPlugin caused problems w/ HSWP, but it seems this is known. This is unfortunate as it's an important part of optimizing our build. Thanks for HSWP though, it's saved us a ton of time during dev.

@adriantoine
Copy link

I'm having issues while using this plugin with webpack.IgnorePlugin, here's my config:

new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/),

and here's the error I get:

/Users/adrien/Projects/tray/website/node_modules/hard-source-webpack-plugin/lib/hard-context-module-factory.js:74
    var identifier = identifierPrefix + module.identifier();
                                              ^

TypeError: Cannot read property 'identifier' of undefined
    at /Users/adrien/Projects/tray/website/node_modules/hard-source-webpack-plugin/lib/hard-context-module-factory.js:74:47
    at /Users/adrien/Projects/tray/website/node_modules/webpack/lib/ContextModuleFactory.js:37:22
    at /Users/adrien/Projects/tray/website/node_modules/tapable/lib/Tapable.js:204:11
    at ContextModuleFactory.cmf.plugin (/Users/adrien/Projects/tray/website/node_modules/webpack/lib/IgnorePlugin.js:28:24)
    at /Users/adrien/Projects/tray/website/node_modules/tapable/lib/Tapable.js:206:14
    at ContextModuleFactory.cmf.plugin (/Users/adrien/Projects/tray/website/node_modules/webpack/lib/IgnorePlugin.js:30:13)
    at ContextModuleFactory.applyPluginsAsyncWaterfall (/Users/adrien/Projects/tray/website/node_modules/tapable/lib/Tapable.js:208:13)
    at ContextModuleFactory.create (/Users/adrien/Projects/tray/website/node_modules/webpack/lib/ContextModuleFactory.js:26:7)
    at next (/Users/adrien/Projects/tray/website/node_modules/hard-source-webpack-plugin/lib/hard-context-module-factory.js:59:15)
    at HardContextModuleFactory.create (/Users/adrien/Projects/tray/website/node_modules/hard-source-webpack-plugin/lib/hard-context-module-factory.js:66:3)
    at iteratorFactory (/Users/adrien/Projects/tray/website/node_modules/webpack/lib/Compilation.js:209:12)
    at /Users/adrien/Projects/tray/website/node_modules/webpack/node_modules/async/dist/async.js:3025:16
    at eachOfArrayLike (/Users/adrien/Projects/tray/website/node_modules/webpack/node_modules/async/dist/async.js:941:9)
    at eachOf (/Users/adrien/Projects/tray/website/node_modules/webpack/node_modules/async/dist/async.js:991:5)
    at Object.eachLimit (/Users/adrien/Projects/tray/website/node_modules/webpack/node_modules/async/dist/async.js:3089:3)
    at Compilation.addModuleDependencies (/Users/adrien/Projects/tray/website/node_modules/webpack/lib/Compilation.js:190:9)
    at Compilation.processModuleDependencies (/Users/adrien/Projects/tray/website/node_modules/webpack/lib/Compilation.js:175:8)
    at _this.buildModule.err (/Users/adrien/Projects/tray/website/node_modules/webpack/lib/Compilation.js:315:13)
    at building.forEach.cb (/Users/adrien/Projects/tray/website/node_modules/webpack/lib/Compilation.js:125:27)
    at Array.forEach (native)
    at callback (/Users/adrien/Projects/tray/website/node_modules/webpack/lib/Compilation.js:125:13)
    at module.build (/Users/adrien/Projects/tray/website/node_modules/webpack/lib/Compilation.js:147:11)
    at /Users/adrien/Projects/tray/website/node_modules/webpack/lib/NormalModule.js:210:10
    at /Users/adrien/Projects/tray/website/node_modules/webpack/lib/NormalModule.js:162:10
    at /Users/adrien/Projects/tray/website/node_modules/loader-runner/lib/LoaderRunner.js:370:3
    at iterateNormalLoaders (/Users/adrien/Projects/tray/website/node_modules/loader-runner/lib/LoaderRunner.js:211:10)
    at Array.<anonymous> (/Users/adrien/Projects/tray/website/node_modules/loader-runner/lib/LoaderRunner.js:202:4)
    at Storage.finished (/Users/adrien/Projects/tray/website/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:38:15)
    at /Users/adrien/Projects/tray/website/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:69:9
    at /Users/adrien/Projects/tray/website/node_modules/graceful-fs/graceful-fs.js:78:16

if I remove the IgnorePlugin, it works.

@mzgoddard
Copy link
Owner Author

Thank you @adriantoine and @legomushroom for your debug info for IgnorePlugin. Let me know if 0.3.9 does or doesn't work for you.

@mzgoddard
Copy link
Owner Author

Ooop. 0.3.9 will be up in a bit. I left out a bit of code in my last merge.

@adriantoine
Copy link

Hey @mzgoddard, sorry I didn't answer earlier (I couldn't test), it's fixed in v0.3.9, thanks for your works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants