Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-version Support? #4

Closed
cathalgarvey opened this issue Sep 23, 2016 · 3 comments
Closed

Multi-version Support? #4

cathalgarvey opened this issue Sep 23, 2016 · 3 comments

Comments

@cathalgarvey
Copy link

Hi Matt, awesome work and a very enjoyable write-up, thank you.

I've looked over the code briefly, and it's very neatly structured and compartmentalised. None of the dependencies look like no-gos for Python3, and the file-handling seems to be compartmentalised by PIL/Pillow.

So, I'm wondering why this is Python2 only? If it's merely personal preference and all it would take are some modernisations from __future__ and some print function calls (or six, if it came to that), would you accept pull requests to make this work on both?

@mzucker
Copy link
Owner

mzucker commented Sep 24, 2016

Sure, happy to accept pull requests, especially if you tell me also how to test w/ Python 3 on my machine (I'm a Python 2 user, but it's probably past time to upgrade...)

@daneah daneah mentioned this issue Sep 28, 2016
@mzucker
Copy link
Owner

mzucker commented Sep 29, 2016

Think we got this one settled in 0701e13

@mzucker mzucker closed this as completed Sep 29, 2016
@cathalgarvey
Copy link
Author

\o/ Great news, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants