Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing #8

Closed
daneah opened this issue Sep 28, 2016 · 2 comments
Closed

Unit testing #8

daneah opened this issue Sep 28, 2016 · 2 comments

Comments

@daneah
Copy link

daneah commented Sep 28, 2016

I recently found noteshrink and I'm fond of its utility! Thanks for giving it to the world!

In order to confidently make noteshrink compatible with Python 3 (per issue #4), introduction of unit tests would be beneficial. This will provide a baseline to compare behaviors as well as help with alteration of existing features/introduction of new features over time.

I would like to help with this, but I want to feel this out before I get the horse too far ahead of the cart! The code structure seems amenable to unit testing for the most part.

@mzucker
Copy link
Owner

mzucker commented Sep 28, 2016

I think that unit testing is a great idea for larger projects, less so small, single-file utilities like noteshrink. The project is MIT-licensed, so feel free to fork your own version and add unit tests to it as you see fit. In the meantime, I'm going to close this issue, bearing in mind that #4 will likely require fairly minor changes.

Thanks for your feedback!

@mzucker mzucker closed this as completed Sep 28, 2016
@daneah
Copy link
Author

daneah commented Sep 29, 2016

That's fair—was going to follow up with a pull request for the changes I'd made to get Python 3 working on my end but I see I've been beaten to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants