-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnome 40 support #146
Comments
I definitely intend to keep this extension going. However, I'm personally still using GNOME 3.36 and my spare time is rather limited right now. We also haven't fully finished 3.38 support ( #125 ). Contributors for GNOME 40 support are very welcome! At least we can gather an initial list of error messages and what features are broken. |
There's a (official?) guide to porting extensions to Gnome 40 here: https://gjs.guide/extensions/upgrading/gnome-shell-40.html. |
Neat! I wasn't aware of gjs.guide, thanks for sharing that resource. |
|
@ebeem Good to hear from you again! I was planning to strip this extension back to its essentials and basically start from scratch to establish GNOME 40 support. I already had a peek at it in a Fedora 34 beta VM and I suspect that nothing in our codebase will be compatible. We can start small and implement just the 2D workspace switcher and then continue to add the missing features (thumbnails, overview integration, animations etc.) later. |
@mzur probably the workspaces grid in the overview will be the most difficult to implement. Now that the overview design is different, I think that we need to also consider the new design and come up with a good design so we save space while displaying a grid. I have no idea in my mind right now, it doesn't seem to be easy as the workspaces are shown along with the applications now in the second workspaces overview. Maybe this is the feature that we need to be patient with for now and delay it. |
I agree - I think with the UX for workspaces changing so much, it makes sense to just strip everything back and start with the bare minimum: being able to switch workspace on a 2D grid with a popup indicator of the grid as you switch. I don't see how to fit a 2D grid onto the new overview design either. It's not just the workspace row at the top that would need to change: you can also now see the next/previous workspace at the edge of the screen. If that worked in 2D then that would be insanely awesome but I imagine that would be very difficult. |
@tom-james-watson Exactly, we will need to take care of the two views. Regarding the next/previous view of the workspaces. At least I can see that the design is easy, we just somehow want to zoom it out so the workspaces above/below are visible. I am not sure how easy or hard that will be, I will need to check the code first. Maybe this feature can be implemented with no delay. However, the second view where the workspaces are displayed along with the applications, I am not sure how we will design it. Maybe we need to do some sketches first and plan it right as we did back in #13 (comment) |
I already checked this out. It's not easy to migrate to
We will need to rewrite a lot of the code from scratch as we came to realize some features will need core changes. I will start by trying to extend |
Thanks a lot @ebeem! Don't hesitate to open a draft PR early so we can have a look and contribute. |
@ebeem At the least, I can take care of the settings window, as I have ported one of my other extensions recently. |
@mzur Thanks! |
I ported the settings in 222fa8a. I'll merge this with your changes, @ebeem, once you created your PR. I'll disable the settings that are not yet implemented then. @tom-james-watson Thanks a lot for your link to the guide, again! It's so refreshing to actually know how things should be done and what functions exist 😄 |
Anyone who wants to contribute is welcome to take a look at #152. Even reports of bugs and yet unknown issues with the WIP code are helpful. Closing this in favor of the PR. |
Just wondering if anyone has looked into Gnome 40 and if it will be in any way possible to keep the extension working? Looks like it includes some pretty big changes, especially around workspaces.
The text was updated successfully, but these errors were encountered: