Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding of workspace thumbnails in overview #181

Open
mzur opened this issue Sep 24, 2021 · 1 comment
Open

Fix padding of workspace thumbnails in overview #181

mzur opened this issue Sep 24, 2021 · 1 comment
Labels
gnome-40 help wanted Extra attention is needed

Comments

@mzur
Copy link
Owner

mzur commented Sep 24, 2021

The workspace thumbnails in the overview should have vertical padding (same as horizontal). Maybe related to #177

@mzur mzur added help wanted Extra attention is needed gnome-40 labels Sep 24, 2021
@ebeem
Copy link
Collaborator

ebeem commented Dec 16, 2021

You're right, I think it's related to #177
The reason behind that is because we actually have lists in the WorkspaceSwitcherPopupList equal to the amount of rows we have in wsmatrix. Long story with the limitation faced while implementing a grid in the WorkspaceSwitcherPopupList.

I think to fix this, we need to build a St.ScrollView to contain a single list which has all the workspaces.
In other words, _lists should be one list instead of a array of lists

var WorkspaceSwitcherPopupList = GObject.registerClass({
Signals: {
'item-activated': {param_types: [GObject.TYPE_INT]},
'item-entered': {param_types: [GObject.TYPE_INT]},
'item-removed': {param_types: [GObject.TYPE_INT]}
},
}, class WorkspaceSwitcherPopupList extends St.BoxLayout {
_init(thumbnails, workspaceName, options) {
super._init({
style_class: 'switcher-list',
vertical: true,
style: `spacing: ${ITEM_SPACING}`,
});
this._lists = [];
this._thumbnails = thumbnails;
this._workspaceName = workspaceName;
this._scale = options.scale;
this._showThumbnails = options.showThumbnails;
this._showWorkspaceName = options.showWorkspaceNames;

I think this issue is a high priority as it will help a lot in styling and most likely contribute to fixing #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gnome-40 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants