Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace overview #44

Merged
merged 6 commits into from
Aug 19, 2019
Merged

Workspace overview #44

merged 6 commits into from
Aug 19, 2019

Conversation

mzur
Copy link
Owner

@mzur mzur commented Aug 10, 2019

This implements the workspace switcher popup as a simple workspace overview that does not automatically disappear (as discussed in #13).

video

I still get warnings like these in the log:

Window manager warning: Overwriting existing binding of keysym 37 with keysym 37 (keycode 10).

They seem to be caused by the new keybindings but I'm not sure. If this is the case, I don't know how to get rid of the warnings.

@mzur
Copy link
Owner Author

mzur commented Aug 10, 2019

I didn't observe the warnings with GNOME 3.30 (#45) so the code is probably fine. I'll wait a few days if someone wants to comment and merge then.

@mzur mzur merged commit 6eb3f73 into master Aug 19, 2019
@mzur mzur deleted the workspace-overview branch August 19, 2019 18:57
@goodwillcoding
Copy link

@mzur : tested the branch, seems to work though wrap around in column/row mode seems to have been broken.

@goodwillcoding
Copy link

also when use Super+W for pop it is not "highlighting" which screen is selected.

mzur added a commit that referenced this pull request Aug 22, 2019
@mzur
Copy link
Owner Author

mzur commented Aug 22, 2019

Thanks for testing! I published a fix for the wraparound mode.

also when use Super+W for pop it is not "highlighting" which screen is selected.

What do you mean by that? When I press Super+W the current workspace is highlighted (see video above).

@goodwillcoding
Copy link

I can confirm wrap around has been fixed

@goodwillcoding
Copy link

So here is the example of the current workspace not highlighted when Super+W triggerd overlay appears. As you can see I do not know which space I am on. This does not happen when I do no overlay navigation.

wsmatrix

Also as side note, you can see in a gif that it move a tad after appearance ... a tween?

@mzur
Copy link
Owner Author

mzur commented Aug 23, 2019

I see, this only affects the overview when thumbnails are disabled. I opened a new issue for that (#48).

Does the workspace switcher popup also move when you switch workspaces the usual way?

@goodwillcoding
Copy link

@mzur : so it was hard to tell originally it does move when doing regular workspace switching.

@mzur
Copy link
Owner Author

mzur commented Aug 24, 2019

Does it also move if you disable this extension and use the default workspace switcher?

@goodwillcoding
Copy link

yes it does move.

@mzur
Copy link
Owner Author

mzur commented Aug 27, 2019

In that case this would be an upstream issue of GNOME or maybe your theme and not related to this extension. But thanks again for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants