-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo Thoughts #56
Comments
I imagine that as long it is clear that the logos identify the language rather than the kernel, it will be OK. I will look for their licenses. |
Here's the Logo page which references the Trademark Guidelines The particularly relevant bits:
In the project README we probably have to include:
We also can not sell items using the Node.js logo. This is open source software designed to help people interact with node, learn, do research, and develop software. It would be pretty crazy for us to run into problems here. |
If you're ok with it, I'm happy to submit a PR updating the README and the bundled logo. |
By the way, I don't mean to overwrite the main IJavascript logo, only the language icon shown in the corner of a notebook. |
OK.
You'd need to edit the logo filename here:
https://github.com/n-riesco/ijavascript/blob/master/bin/ijavascript.js#L297
and here:
https://github.com/n-riesco/ijavascript/blob/master/bin/ijavascript.js#L299
I would also add a LICENSE file to the images folder listing the filenames of Joyent's files and providing a link to Joyent's trademark guidelines.
|
Sorry that took me a bit to get done. It's in #57. |
Hey @n-riesco, I know I'm the one that pestered about a logo sometime ago. After having used this for a while, I'd love to see the standard node logo to show similar to how IPython just shows Python's logo:
For ijavascript (which is definitely node and not browser javascript), the logo should be the node logo (this one comes from the nodejs github org):
Scala, R, and many other kernels all use the logo of their respective language. I do think it's ok for the Babel kernel to use:
The text was updated successfully, but these errors were encountered: