Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure to use the config by default in iroh doctor report #1057

Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix: make sure to use the config by default in iroh doctor report #1057

merged 1 commit into from
Jun 1, 2023

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Jun 1, 2023 •
edited
Loading

  • by default, use config
  • if explicitily provided, use stun_host and stun_port
  • fail if config does not contain a derp map and nothing was explicitly provided

@rklaehn rklaehn mentioned this pull request Jun 1, 2023
Closed
Arqu
Arqu approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rklaehn rklaehn merged commit fcc74b8 into x-hp Jun 1, 2023
9 of 15 checks passed
@rklaehn rklaehn deleted the x-hp-report-use-config branch June 1, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arqu Arqu Arqu approved these changes

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rklaehn @dignifiedquire @Arqu