refactor: replace warp with axum for the test server #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
force-pushed
the
s/warp/axum
branch
2 times, most recently
from
1abba2f
to
32d2c51
Compare
this also makes the tests not create a file.
b5
approved these changes
Jun 22, 2023
Don't be so humble. I think this 👍 is good enough for me. We already have axum as a test dependency, so it's not like it is a controversial choice... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also makes the tests not create a file.
With very friendly and polite support from GPT-4
I had to exclude windows from the range request tests because axum has some issues there. But I think this is OK. The purpose of the test is to make sure we properly deal with range requests etc.