refactor: pluggable metrics #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
added
refactor
Arqu
force-pushed
the
arqu/generic-metrics
branch
from
276a863
to
1f5b26e
Compare
|
The sync/async mix is a bit confusing and potentially problematic, let me know if you have a plan on how to resolve or if you have specific questions. |
Arqu
force-pushed
the
arqu/generic-metrics
branch
2 times, most recently
from
4c75794
to
93ef21a
Compare
7 tasks
* refactor(iroh-metrics): avoid macro uses * bring back a little macro * remove unused deps * cargo fmt
Arqu
force-pushed
the
arqu/generic-metrics
branch
from
39bfe16
to
054b6bd
Compare
dignifiedquire
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to refactor some of the constants & complete the move of the netcheck, magicsock and portmap metrics.
Would like a first 👀 on the 🍝 I've made here.