Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve provider fetching #124

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Conversation

dignifiedquire
Copy link
Contributor

Integrates libp2p/rust-libp2p#2712 to fetch providers more quickly. For widely available providers this reduces the fetch time considerably.

Integrates libp2p/rust-libp2p#2712 to fetch providers more quickly. For widely available providers this reduces the fetch time considerably.
Arqu
Arqu previously approved these changes Jun 16, 2022
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this one, if it just resolves most of the 0 provider requests we're ~10% better off than before.

iroh-p2p/src/service.rs Outdated Show resolved Hide resolved
improve bitswap connection handling & connection parameters
@Arqu
Copy link
Collaborator

Arqu commented Jun 16, 2022

Tested locally, after some warmup time/requests, things seem a lot better than before.

@dignifiedquire dignifiedquire merged commit feeff29 into main Jun 16, 2022
@dignifiedquire dignifiedquire deleted the feat-faster-dht-provider branch June 16, 2022 21:26
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dignifiedquire pushed a commit that referenced this pull request Feb 20, 2023
This makes it so that the provider is allowed to close the connection
after a transfer is completed, without the getter resulting in an
error.

It modifies the provider to only emit the transfer completed once the
data has actually reached the client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants