chore: Specify resolver 2 for entire workspace #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the crates use edition 2021 which use this resolver, but the workspace itself defaults to resolver 1. This creates confusion and it is better to set everything to resolver 2.
dignifiedquire
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the crates use edition 2021 which use this resolver, but the
workspace itself defaults to resolver 1. This creates confusion and
it is better to set everything to resolver 2.
Notes & open questions
This solves the following error since rust 1.72:
cargo-json-read-from-string: warning: some crates are on edition 2021 which defaults to ‘resolver = "2"‘, but virtual workspaces default to ‘resolver = "1"‘
note: to keep the current resolver, specify ‘workspace.resolver = "1"‘ in the workspace root’s manifest
note: to use the edition 2021 resolver, specify ‘workspace.resolver = "2"‘ in the workspace root’s manifest
Change checklist
Documentation updates if relevant.Tests if relevant.