feat: get list of `ConnectionInfo`s or an individual node's `ConnectionInfo` #1435

ramfox · 2023-08-31T01:48:02Z

Description

Display connection information for all nodes we have connected with or have supplied our node with addresses for.

Display connection information on a particular node, using its node id.

Change checklist

Self-review.
Documentation updates if relevant.

b5 · 2023-08-31T01:53:16Z

ZOMG I WANT THIS.

Howeve, given that you had to censor the screenshot, I'd say right off the bat we should go with listing by NodeID, and omitting IP addresses. wdyt?

ramfox · 2023-08-31T02:05:17Z

@b5

ZOMG I WANT THIS.

Howeve, given that you had to censor the screenshot, I'd say right off the bat we should go with listing by NodeID, and omitting IP addresses. wdyt?

What do you think is the "right" language when we don't have any latency info?

b5 · 2023-08-31T02:07:40Z

Can we use short NodeIDs, like we do for doc & author ids in the console? We could also do this in a follow-up.

What do you think is the "right" language when we don't have any latency info?

with a latency of Unknown, using "unknown" is the right thing to do here imho

ramfox · 2023-08-31T02:08:19Z

iroh/src/commands.rs

+            Self::Connections => {
+                let mut connections = client.server_streaming(ConnectionsRequest).await?;
+                println!("Connections:");
+                while let Some(Ok(Ok(ConnectionsResponse { node_info }))) = connections.next().await


@rklaehn can I get some RPC help?

I don't understand how I ended up with double Results. Did I do something incorrectly, or is expected?

I don't understand how I ended up with double Results. Did I do something incorrectly, or is expected?

This is expected behavior. The first Result is around a connection error while reading the response, and the second Result is the RpcResult that you are sending as Item in the stream.

ramfox · 2023-08-31T02:47:41Z

@b5

Connections:
	hpf6qa4h…
	derp region: 1
	direct connection
	5175250ns latency

	nzx6mxi6…
	derp region: 1
	relay connection
	unknown latency

	xce2h4zq…
	derp region: 1
	relay connection
	unknown latency

	xuko33wo…
	derp region: 1
	direct connection
	3489375ns latency

If you write out one example of how you think it should look, I'll just do it, because it doesn't look right yet but i don't know how to adjust it.

ramfox · 2023-08-31T02:56:04Z

Connections:
	xuko33wo…
	derp region: 1
	connection type: direct
	latency: 3489375ns

?

b5 · 2023-08-31T03:00:55Z

zomg you fast. the problem is you're not doing one entry per line. aim for a table layout:

nodeId    derp region    conn type    latency
xuko33wo…  1             direct       56.5678ms

Huge win here is each row will be a constant-ish length except for the last value (latency), which makes the formatting much easier, just use \t characters between values.

latency should be displayed in ms not ns.

ramfox · 2023-08-31T03:39:12Z

will look at other ways to display latency tomorrow!

Frando

Looks good to me!

Maybe let's add a node connection NODE_ID command as well that shows all details for a single node id, including IP addresses. This info is available at the node, so I think it makes sense to expose it in some way. Useful for debugging etc.

Frando · 2023-08-31T14:20:58Z

iroh/src/commands.rs

+            Self::Connections => {
+                let mut connections = client.server_streaming(ConnectionsRequest).await?;
+                println!("Connections:");
+                while let Some(Ok(Ok(ConnectionsResponse { node_info }))) = connections.next().await


I don't understand how I ended up with double Results. Did I do something incorrectly, or is expected?

This is expected behavior. The first Result is around a connection error while reading the response, and the second Result is the RpcResult that you are sending as Item in the stream.

iroh/src/node.rs

iroh/src/rpc_protocol.rs

dignifiedquire · 2023-08-31T16:02:42Z

https://github.com/manlge/human-time makes nicer timestamps

dignifiedquire · 2023-08-31T16:04:31Z

https://github.com/Nukesor/comfy-table can render easy very nice tables :)

dignifiedquire · 2023-08-31T16:06:48Z

Can extend this functionality to the console.

lets add this to the repl for sure

dignifiedquire · 2023-08-31T16:08:54Z

We should add this to the client api as well, this will be very useful from the API

…on we know about

…o the DERP region id

ramfox · 2023-09-01T03:22:39Z

`iroh node connections`

CLI

Console

Adjusted the node id field to show the full ID, otherwise you wouldn't be able to fetch any individual node connection information with iroh node connection NODE_ID

`iroh node connection NODE_ID`

CLI

Console

adds `connection_info(node_id: PublicKey)` method to the client & adds `node connection NODE_ID` to the repl also adjusts some formatting

ramfox requested review from Frando and b5 August 31, 2023 01:48

ramfox self-assigned this Aug 31, 2023

ramfox requested a review from rklaehn August 31, 2023 02:06

ramfox commented Aug 31, 2023

View reviewed changes

ramfox changed the base branch from main to ramfox/peer_info August 31, 2023 03:47

ramfox marked this pull request as ready for review August 31, 2023 03:47

Frando reviewed Aug 31, 2023

View reviewed changes

b5 added this to the v0.6.0-alpha2 milestone Aug 31, 2023

ramfox mentioned this pull request Aug 31, 2023

feat: get NodeInfos from the MagicEndpoint #1375

Closed

3 tasks

ramfox changed the base branch from ramfox/peer_info to main August 31, 2023 17:03

ramfox changed the title ~~feat: iroh node connections command to list connection info for all known nodes~~ feat: get list of ConnectionInfos on the iroh client, CLI, & console Aug 31, 2023

ramfox force-pushed the ramfox/connections_command branch 3 times, most recently from 0be217a to 7a1cbe8 Compare August 31, 2023 22:15

ramfox added 4 commits August 31, 2023 19:29

adjust EndpoingInfo to better suit our needs

204b8e8

add tests

f0e520d

rename from PeerInfo to NodeInfo

6537efe

clippy

6ad9f3a

ramfox added 7 commits August 31, 2023 19:29

Add connections rpc method that returns NodeInfo on each connecti…

ae22b23

…on we know about

add fmt_connections method to output connection info

fd195d4

clippy / docs clean up

5ffc259

adjust ui

59c52f4

adjust ui

6df70ca

rename to ConnectionInfo and connection_infos

7618624

rename derp_addr to derp_region where we are actually referring t…

15ddf87

…o the DERP region id

ramfox force-pushed the ramfox/connections_command branch from 7a1cbe8 to 15ddf87 Compare August 31, 2023 23:30

ramfox changed the title ~~feat: get list of ConnectionInfos on the iroh client, CLI, & console~~ feat: get list of ConnectionInfos or an individual node's ConnectionInfo Sep 1, 2023

ramfox added 2 commits August 31, 2023 23:40

add iroh node connection NODE_ID command

e12f540

adds `connection_info(node_id: PublicKey)` method to the client & adds `node connection NODE_ID` to the repl also adjusts some formatting

remove unused crate from cargo file

89abdc0

ramfox requested review from Frando and dignifiedquire September 1, 2023 04:12

dignifiedquire approved these changes Sep 1, 2023

View reviewed changes

dignifiedquire added this pull request to the merge queue Sep 1, 2023

Merged via the queue into main with commit bdf966e Sep 1, 2023
15 checks passed

ramfox deleted the ramfox/connections_command branch November 1, 2023 14:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: get list of `ConnectionInfo`s or an individual node's `ConnectionInfo` #1435

feat: get list of `ConnectionInfo`s or an individual node's `ConnectionInfo` #1435

ramfox commented Aug 31, 2023 •

edited

b5 commented Aug 31, 2023

ramfox commented Aug 31, 2023 •

edited

b5 commented Aug 31, 2023

ramfox Aug 31, 2023

Frando Aug 31, 2023 •

edited

ramfox commented Aug 31, 2023

ramfox commented Aug 31, 2023

b5 commented Aug 31, 2023

ramfox commented Aug 31, 2023

Frando left a comment

Frando Aug 31, 2023 •

edited

dignifiedquire commented Aug 31, 2023

dignifiedquire commented Aug 31, 2023

dignifiedquire commented Aug 31, 2023

dignifiedquire commented Aug 31, 2023

ramfox commented Sep 1, 2023

feat: get list of ConnectionInfos or an individual node's ConnectionInfo #1435

feat: get list of ConnectionInfos or an individual node's ConnectionInfo #1435

Conversation

ramfox commented Aug 31, 2023 • edited

Description

Change checklist

b5 commented Aug 31, 2023

ramfox commented Aug 31, 2023 • edited

b5 commented Aug 31, 2023

ramfox Aug 31, 2023

Choose a reason for hiding this comment

Frando Aug 31, 2023 • edited

Choose a reason for hiding this comment

ramfox commented Aug 31, 2023

ramfox commented Aug 31, 2023

b5 commented Aug 31, 2023

ramfox commented Aug 31, 2023

Frando left a comment

Choose a reason for hiding this comment

Frando Aug 31, 2023 • edited

Choose a reason for hiding this comment

dignifiedquire commented Aug 31, 2023

dignifiedquire commented Aug 31, 2023

dignifiedquire commented Aug 31, 2023

dignifiedquire commented Aug 31, 2023

ramfox commented Sep 1, 2023

iroh node connections

iroh node connection NODE_ID

feat: get list of `ConnectionInfo`s or an individual node's `ConnectionInfo` #1435

feat: get list of `ConnectionInfo`s or an individual node's `ConnectionInfo` #1435

ramfox commented Aug 31, 2023 •

edited

ramfox commented Aug 31, 2023 •

edited

Frando Aug 31, 2023 •

edited

Frando Aug 31, 2023 •

edited

`iroh node connections`

`iroh node connection NODE_ID`