perf(iroh-net): simplify stun::is check #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is run on every packet, and showed up in some profiling as not being as cheap as it should be
Comment on lines
+69
to
+70
| // const MAGIC_COOKIE: Cookie = Cookie(0x2112_A442); | ||
| const COOKIE: [u8; 4] = 0x2112_A442u32.to_be_bytes(); |
There was a problem hiding this comment.
why the need to copy the constant?
There was a problem hiding this comment.
because I can't get it out of the library as constant time
Comment on lines
+514
to
+516
| fn test_stun_cookie() { | ||
| assert_eq!(stun_rs::MAGIC_COOKIE, COOKIE); | ||
| } |
There was a problem hiding this comment.
we can do this in compile time
There was a problem hiding this comment.
the equality check/conversion is not constant time, so not sure how to do that
divagant-martian
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is run on every packet, and showed up in some profiling as not being as cheap as it should be