-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iroh-net): enforce storing a single derp region per peer #1607
Merged
divagant-martian
merged 16 commits into
n0-computer:main
from
divagant-martian:store-relay-latency-appart
Oct 12, 2023
Merged
fix(iroh-net): enforce storing a single derp region per peer #1607
divagant-martian
merged 16 commits into
n0-computer:main
from
divagant-martian:store-relay-latency-appart
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this looks pretty good, what is missing for this to be ready? |
@dignifiedquire was built on top of #1606 so was waiting for that. Otherwise I think it's ready. I'll update the description with the relevant info |
dignifiedquire
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Endpoint contained
SendAddr
instead ofip
,port
pairs. This is problematic for a couple of reasons:So this PR enforces storing a single derp region per peer. Some relevant note with these changes:
Notes & open questions
Basically TLDR, next step is adding ping via relays with some appropriate tests. This should at a minimum solve the second part of clean up output for
node connections
#1576Change checklist