perf: improve derp connection establishment #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
approved these changes
Oct 16, 2023
iroh-net/src/derp/http/client.rs
Outdated
| let err = first_err.unwrap(); | ||
| Err(err) | ||
|
|
||
| Err(first_err.unwrap()) |
There was a problem hiding this comment.
seems a bit arbitrary to just return the first error.
There was a problem hiding this comment.
logging them at least now
flub
approved these changes
Oct 16, 2023
iroh-net/src/derp/http/client.rs
Outdated
Comment on lines
655
to
659
| let conn = this.dial_node(&node).await; | ||
| match conn { | ||
| Ok(conn) => Ok((conn, node)), | ||
| Err(e) => Err(e), | ||
| } |
There was a problem hiding this comment.
optional, but isn't this this.dial_node(&node).await.map(|c| (c, node))?
iroh-net/src/derp/http/client.rs
Outdated
| } | ||
| Err(e) => { | ||
| if first_err.is_none() { | ||
| first_err = Some(e); |
There was a problem hiding this comment.
related to @rklaehn 's comment below, unless you return a Vec of errors you'll always have an arbitrary choice. Probably easier is to tracing::error!() log all the error cases here? or at least warn!.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctor derp-regionscommand