fix(iroh-net): temp fix for progress bar when downloading a hash seq #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is an important information
download is now the main op, get is implemented in terms of download
rklaehn
changed the title
|
I think this is good enough. One addition I would like to see is to show the total number of bytes downloaded, maybe at the end |
# Conflicts: # iroh-bytes/src/get.rs # iroh/src/commands/get.rs
dignifiedquire
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the download progress bar when downloading a hash seq where the size is not known.
Notes & open questions
Is this good enough? The only way to get a proper progress for a hash seq where you don't know the overall size is to do a verified size request before and give the sum of the sizes to the progress logic. But that would be another roundtrip. Fine for GUI stuff, but in many cases we don't really care, so I would hate to do this all the time.
Change checklist