Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iroh-net: doctor improvements #1663

Merged
merged 3 commits into from
Oct 18, 2023
Merged

iroh-net: doctor improvements #1663

merged 3 commits into from
Oct 18, 2023

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Oct 18, 2023

Description

  • doctor accept can accept multiple connections at the same time (only the first one will get a GUI).
  • gui on server side is properly cleared

Notes & open questions

This is useful when running doctor accept on a server, for async dogfooding.

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

- doctor accept can accept multiple connections at the same time (only the
first one will get a GUI).
- gui on server side is properly cleared
@rklaehn rklaehn changed the title doctor improvements: iroh-net: doctor improvements Oct 18, 2023
@b5 b5 added this to the v0.8.0 milestone Oct 18, 2023
@rklaehn
Copy link
Contributor Author

rklaehn commented Oct 18, 2023

@b5 this came out of the dogfooding session yesterday. It would be nice if you could just leave the accept running indefinitely on a server.

@rklaehn rklaehn added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 8169053 Oct 18, 2023
15 checks passed
@dignifiedquire dignifiedquire deleted the doctor-multi-accept branch November 1, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants