-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): improve the output of node connections
and node connection
#1683
feat(console): improve the output of node connections
and node connection
#1683
Conversation
node connections
and node connection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ux approval only, def get a code review as well
I'm a fan. My one nit: the "525μs"
feels a bit noisy, but it's not too bad, and not really worth removing. from a UX perspective this is a big win. Thanks!
/// The type of connection we have to the peer, either direct or over relay. | ||
pub conn_type: ConnectionType, | ||
/// The latency of the `conn_type`. | ||
pub latency: Option<Duration>, | ||
/// Duration since the last time this peer was used. | ||
pub last_used: Option<Duration>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not report last_used on a per addr level?
this was pretty annoying taking into account how little it changed but output should be a bit more useful now as discussed |
this should close #1576, right? |
for now yes, if we want further goodies we can open a new one. Issue linked, ty |
Description
better formatting, plus giving information about the last time a peer was used, and which of it's addresses are in use
Notes & open questions
Sample output:
Change checklist