feat(iroh): pass a runtime to Doc client to spawn close task on drop #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
changed the title
Frando
force-pushed
the
fix-iroh-sync-drop
branch
from
0799b8e
to
3a99396
Compare
Frando
changed the title
Frando
approved these changes
Oct 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
divagant-martian
pushed a commit
to divagant-martian/iroh
that referenced
this pull request
Oct 31, 2023
…0-computer#1758) We spawn a tokio task when dropping a client `Doc` handle to notify the node that the document was closed. This does not work in the FFI currently because the FFI does not run in a global tokio context. Instead we now always pass a `runtime::Handle` into the client which can be used to spawn tasks independently of running in a tokio context. --------- Co-authored-by: Franz Heinzmann (Frando) <frando@unbiskant.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We spawn a tokio task when dropping a client
Dochandle to notify the node that the document was closed. This does not work in the FFI currently because the FFI does not run in a global tokio context. Instead we now always pass aruntime::Handleinto the client which can be used to spawn tasks independently of running in a tokio context.