Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iroh): store rpc port in iroh data dir #1783

Merged
merged 7 commits into from
Nov 9, 2023
Merged

feat(iroh): store rpc port in iroh data dir #1783

merged 7 commits into from
Nov 9, 2023

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Nov 8, 2023 •
edited

  • prevents iroh from being started in the same iroh data dir
  • retrieves the rpc port from the rpc.lock file
  • removes the --rpc-port argument from all commands other than start

This also changes the way in put handling is done on start, as I discovered some issues with the current state of things.

The way it works now is

# no adding of content
> iroh start
# adding from stdin
> iroh start --source STDIN
# adding from file
> iroh start --source ./path/to/file

Closes #1281

@dignifiedquire dignifiedquire self-assigned this Nov 8, 2023
@dignifiedquire
feat(iroh): store rpc port in iroh data dir
ed85fb0 
- prevents iroh from being started in the same iroh data dir
- retrieves the rpc port from the rpc.lock file
- removes  the `--rpc-port` argument from all commands other than `start`

Closes #1281
@dignifiedquire dignifiedquire added this to the v0.11.0 milestone Nov 8, 2023
ramfox
ramfox approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dogfooded and it works as intended!

iroh/src/util/path.rs Outdated Show resolved Hide resolved
@Arqu Arqu mentioned this pull request Nov 9, 2023
Merged
@dignifiedquire dignifiedquire added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit d471477 Nov 9, 2023
15 checks passed
@dignifiedquire dignifiedquire deleted the feat-rpc-iroh-dir branch November 9, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arqu Arqu Arqu approved these changes

@ramfox ramfox ramfox approved these changes

Assignees

@dignifiedquire dignifiedquire

Labels
None yet
Projects
iroh
Archived in project
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Prevent multiple iroh daemon processes from using the same IROH_DATA_DIR
3 participants
@dignifiedquire @Arqu @ramfox