Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: more renaming of the term peer id to node id #1789

Merged
merged 1 commit into from
Nov 9, 2023
Merged

refactor: more renaming of the term peer id to node id #1789

merged 1 commit into from
Nov 9, 2023

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Nov 9, 2023

Description

some more purging of the term peer id to be consistent

Notes & open questions

  1. There are some structs like PeerIdBytes.
  • Do we need them at all, now that PeerId is also 32 bytes?
  • Should they also be renamed?
  1. There are some places where I kept the term peer id, e.g. the p2p tls stuff. Also change? It is very internal, so maybe leave it?

@rklaehn rklaehn requested a review from b5 November 9, 2023 14:44
@dignifiedquire dignifiedquire changed the title some more purging of the term peer id to be consistent refactor: more renaming of the term peer id to node id Nov 9, 2023
@rklaehn rklaehn added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 53f1b61 Nov 9, 2023
15 checks passed
@rklaehn rklaehn deleted the s_peer_node branch April 10, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

@b5 b5 Awaiting requested review from b5

Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rklaehn @dignifiedquire