chore: Fix typos #1964
chore: Fix typos #1964
Conversation
| @@ -1018,7 +1018,7 @@ impl DiscoMessageSource { | |||
| /// and start a new one when the current one has finished | |||
| #[derive(Debug)] | |||
| struct EndpointUpdateState { | |||
| /// If running, set to the reason fo the currently the update. | |||
| /// If running, set to the reason for the currently the update. | |||
There was a problem hiding this comment.
This may need DeepL Write or Grammarly.
"entries" would be the correct spelling |
Head branch was pushed to by a user without write access
Done. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
#1966 for flaky test |
|
[files]
extend-exclude = [
".git/",
"iroh-net/proptest-regressions/derp/codec.txt",
]
ignore-hidden = false
[default]
extend-ignore-re = [
"\\[[0-9a-f]{7}\\]",
"let ba =",
"if ab && ba",
'" worl", "d"',
"Replace `currrent` with `current`",
] |
@szepeviktor want to contribute that as a CI step? Probably in In a separate PR of course. |
|
It seems like a never-ending story ... |
Yes, apologies for doing all this on your PR. I think I finally found the problem in our CI setup. I'll probably fix this separately in an other PR and then strip all this noise from this PR and rebase it. |
.github/workflows/tests.yaml
Outdated
| @@ -16,7 +16,7 @@ on: | |||
| git-ref: | |||
| description: 'Which git ref to checkout' | |||
| type: string | |||
| default: 'main' | |||
| default: ${{ github.ref }} | |||
There was a problem hiding this comment.
This is github.ref_name
There was a problem hiding this comment.
You can browse the github context in this workflow run output https://github.com/szepeviktor/byte-level-care/actions/runs/7585113229/job/20660246214
There was a problem hiding this comment.
from https://docs.github.com/en/actions/learn-github-actions/contexts i think github.ref points to the same and is more descriptive? Any reason to prefer ref_name?
This is moved to #1971 btw. Let's merge main into this branch here once that's merged.
|
Thank you. |
## Description Found many misspellings. ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. --------- Co-authored-by: Floris Bruynooghe <flub@n0.computer>
Description
Found many misspellings.
Change checklist