fix(iroh): improve and test blob share #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
reviewed
Jan 29, 2024
iroh/src/client.rs
Outdated
| &self, | ||
| hash: Hash, | ||
| blob_format: BlobFormat, | ||
| no_derp: bool, |
There was a problem hiding this comment.
can we have an enum here? This is just what it puts into the ticket, right?
iroh/src/client.rs
Outdated
|
|
||
| /// Status information about a blob. | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub struct BlobStatus { |
There was a problem hiding this comment.
Would also prefer an enum here. E.g. "partial" is a pretty wide range from 1/1TiB to 999GiB/1TiB. We might want to add some more info here.
There was a problem hiding this comment.
but that information is not known, the store doesn't expose this easily
There was a problem hiding this comment.
Yes, I know. And it is not free to compute. What I'm saying is that with an enum it is easier to evolve it as more information becomes available.
dignifiedquire
force-pushed
the
fix-blob-share
branch
from
de7a768
to
5dcfe3a
Compare
dignifiedquire
force-pushed
the
fix-blob-share
branch
from
5dcfe3a
to
73a06d5
Compare
rklaehn
approved these changes
Feb 2, 2024
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
- adds `iroh.blobs.share` - adds `iroh.blobs.status` Closes n0-computer#1978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iroh.blobs.shareiroh.blobs.statusCloses #1978