Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iroh): Add --log-fd flag on unix #2011

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat(iroh): Add --log-fd flag on unix #2011

merged 2 commits into from
Feb 8, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Feb 8, 2024

Description

This allows you to write log output to a specific filedescriptor in
the shell: iroh --log-fd 3 ... 3>some/file.log

Thus not interfering with normal stdout and stderr output and getting
the full functionality of this.

Notes & open questions

This is splitting off some peripheral stuff from
#1984

Change checklist

  • Self-review.
  • Documentation updates if relevant.

This allows you to write log output to a specific filedescriptor in
the shell: iroh --log-fd 3 ... 3>some/file.log

Thus not interfering with normal stdout and stderr output and getting
the full functionality of this.
iroh/src/main.rs Outdated Show resolved Hide resolved
iroh/src/main.rs Outdated Show resolved Hide resolved
@flub flub enabled auto-merge February 8, 2024 13:18
@flub flub added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit 8e60d1b Feb 8, 2024
18 checks passed
@flub flub deleted the flub/log-fd branch February 8, 2024 14:49
fubuloubu pushed a commit to ApeWorX/iroh that referenced this pull request Feb 21, 2024
## Description

This allows you to write log output to a specific filedescriptor in
the shell: iroh --log-fd 3 ... 3>some/file.log

Thus not interfering with normal stdout and stderr output and getting
the full functionality of this.

## Notes & open questions

This is splitting off some peripheral stuff from
n0-computer#1984

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants