fix(iroh-net): Handle unreachable IPv6 networks better #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we start supporting IPv6 we see this a lot more. If we have a dual-stack machine it does not mean the IPv6 network is routable. If the network is not routable there is no point in trying more attempts in the probeset, this just delays the failure. This results in a visible speed up on my local machine.
dignifiedquire
approved these changes
Feb 19, 2024
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
) ## Description Now that we start supporting IPv6 we see this a lot more. If we have a dual-stack machine it does not mean the IPv6 network is routable. If the network is not routable there is no point in trying more attempts in the probeset, this just delays the failure. This results in a visible speed up on my local machine. ## Notes & open questions Tested on routed and unrouted dual-stack machines ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we start supporting IPv6 we see this a lot more. If we have
a dual-stack machine it does not mean the IPv6 network is routable.
If the network is not routable there is no point in trying more
attempts in the probeset, this just delays the failure. This results
in a visible speed up on my local machine.
Notes & open questions
Tested on routed and unrouted dual-stack machines
Change checklist