tests(iroh-net): ignore save_load_peers test as flaky on windows #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
force-pushed
the
flaky-peer-persistence
branch
from
2cd7fcf
to
978b5dd
Compare
flub
approved these changes
Mar 12, 2024
|
See #2073 for the new flake. when it rains, it poors for flakes it seems. they don't come along in singles. |
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Mar 13, 2024
…computer#2070) ## Description tests(iroh-net): ignore save_load_peers test as flaky on windows Issue is n0-computer#2071 ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Mar 13, 2024
…computer#2070) ## Description tests(iroh-net): ignore save_load_peers test as flaky on windows Issue is n0-computer#2071 ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tests(iroh-net): ignore save_load_peers test as flaky on windows
Issue is #2071
Notes & open questions
Change checklist