refactor(metrics): metrics on by default #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks quite reasonable. What exactly is served on that port if it is enabled? |
rklaehn
approved these changes
Mar 28, 2024
|
It serves prometheus style metrics. You can find the metrics descriptions & definitions in each crates |
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Apr 1, 2024
## Description Now metrics default to serving on `localhost:9090` but you can override with a custom port or turn off if you like with `--metrics-port`. If you want to actually expose the metrics endpoint to the world, it's assumed you will set up a config file with a custom `metrics_addr`. I guess the config override could have been done in a bit more elegant way but didn't want to commit refactoring the `NodeConfig` nor did I want fancy extra task specific fn's. The configuration is limited to the iroh node start path, the rest are ignored as they are expected to be short lived processes. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Apr 4, 2024
## Description Now metrics default to serving on `localhost:9090` but you can override with a custom port or turn off if you like with `--metrics-port`. If you want to actually expose the metrics endpoint to the world, it's assumed you will set up a config file with a custom `metrics_addr`. I guess the config override could have been done in a bit more elegant way but didn't want to commit refactoring the `NodeConfig` nor did I want fancy extra task specific fn's. The configuration is limited to the iroh node start path, the rest are ignored as they are expected to be short lived processes. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Apr 4, 2024
## Description Now metrics default to serving on `localhost:9090` but you can override with a custom port or turn off if you like with `--metrics-port`. If you want to actually expose the metrics endpoint to the world, it's assumed you will set up a config file with a custom `metrics_addr`. I guess the config override could have been done in a bit more elegant way but didn't want to commit refactoring the `NodeConfig` nor did I want fancy extra task specific fn's. The configuration is limited to the iroh node start path, the rest are ignored as they are expected to be short lived processes. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now metrics default to serving on
localhost:9090but you can override with a custom port or turn off if you like with--metrics-port. If you want to actually expose the metrics endpoint to the world, it's assumed you will set up a config file with a custommetrics_addr.I guess the config override could have been done in a bit more elegant way but didn't want to commit refactoring the
NodeConfignor did I want fancy extra task specific fn's.The configuration is limited to the iroh node start path, the rest are ignored as they are expected to be short lived processes.
Notes & open questions
Change checklist