tests(iroh-net): expose run_relay_server and option to skip cert verification to tests
#2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verify in test-utils feature
|
Also added a basic sync test with a ticket that only contains NodeId and relay URL, no direct addrs |
3 tasks
iroh/Cargo.toml
Outdated
| iroh-test = { path = "../iroh-test" } | ||
| iroh-net = { path = "../iroh-net", features = ["test-utils"] } |
There was a problem hiding this comment.
not needed, the test-utils feature already adds this
dignifiedquire
approved these changes
Apr 8, 2024
|
needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test-utilsfeature toiroh-net. If enabled, expose thetest_utilscrate withfn run_relay_serverpublicly.iroh_net::MagicEndpointBuilderto skip relay server SSL certificate verification. The option is behind a#[cfg(any(test, feature = "test-utils"))]iroh::NodeBuilder, behind the samecfgoptionirohwhich usesrun_relay_serverand then downloads a blob by connecting to a node with only node id and relay URL (no direct addresses)Change checklist