Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(iroh-cli): disable metrics #2154

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Apr 5, 2024

fix(tests): disable the metrics port of all cli tests

otherwise they won't run due to "Address already in use (os error 48)".

Somehow one is missing... This still does not work:

> cargo test -- --ignored cli
running 11 tests
test cli_provide_addresses ... ok
test cli_bao_store_migration ... ok
test cli_provide_one_file_single_stdout ... ok
test cli_provide_one_file_basic ... FAILED
test cli_provide_folder ... FAILED
test cli_provide_persistence ... ok
test cli_provide_one_file_single_path ... ok
test cli_provide_from_stdin_to_stdout ... FAILED
test cli_provide_tree ... FAILED
test cli_rpc_lock_restart ... ok

Description

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

otherwise they won't run due to "Address already in use (os error 48)".

Somehow one is missing... This still does not work.
@rklaehn rklaehn force-pushed the disable-metrics-port-in-tests branch from 8f3df12 to 620b366 Compare April 8, 2024 06:52
@rklaehn rklaehn marked this pull request as ready for review April 8, 2024 06:52
@rklaehn rklaehn enabled auto-merge April 8, 2024 06:58
@dignifiedquire dignifiedquire added this to the v0.14.0 milestone Apr 8, 2024
@rklaehn rklaehn added this pull request to the merge queue Apr 8, 2024
@dignifiedquire dignifiedquire changed the title fix(tests): disable the metrics port of all cli tests test(iroh-cli): disable the metrics port Apr 8, 2024
@dignifiedquire dignifiedquire changed the title test(iroh-cli): disable the metrics port test(iroh-cli): disable metrics Apr 8, 2024
Merged via the queue into main with commit 1d51caa Apr 8, 2024
22 checks passed
@dignifiedquire dignifiedquire deleted the disable-metrics-port-in-tests branch April 8, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants