feat: mark iroh-cli's iroh binary as workspace default #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that when you call `cargo run` in the workspace root the `iroh` binary from the iroh-cli crate will be chosen if no additional --bin parameter is passed.
dignifiedquire
approved these changes
Apr 8, 2024
no, this is good, as long as it still lives here |
|
Thank you. Wanted to figure out how to do this today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes sure that when you call
cargo runin the workspace rootthe
irohbinary from the iroh-cli crate will be chosen if noadditional --bin parameter is passed.
Notes & open questions
If we are de-prioritising the iroh cli maybe this is the wrong default
to set?
Change checklist