Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iroh-cli): doctor relay-urls, correct connection logic #2163

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix(iroh-cli): doctor relay-urls, correct connection logic #2163

merged 1 commit into from
Apr 9, 2024

Conversation

dignifiedquire
Copy link
Contributor

No description provided.

rklaehn
rklaehn approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the issue was that after round 1 this assertion was failing?

assert!(!client.is_connected().await?);

because the clients were already connected?

@dignifiedquire
Copy link
Contributor Author

yes, because of recent changes the connection is established more eager

@dignifiedquire dignifiedquire merged commit 314c883 into main Apr 9, 2024
19 of 20 checks passed
@dignifiedquire dignifiedquire deleted the fix-doctor branch April 9, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rklaehn rklaehn rklaehn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dignifiedquire @rklaehn