feat: add discovery option to doctor #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
approved these changes
Apr 15, 2024
ramfox
force-pushed
the
feat/dns-doctor-discovery
branch
from
b61150a
to
b0fadbc
Compare
|
58 changed files? I think sth went wrong in rebasing 😅 |
dignifiedquire
approved these changes
Apr 15, 2024
ramfox
force-pushed
the
feat/dns-doctor-discovery
branch
from
9ae4414
to
ba57ae0
Compare
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Apr 20, 2024
## Description `iroh doctor accept` and `iroh doctor connect` will both run with discovery services enabled by default. Use the `--disable-discovery` flag to disable discovery. This PR also cleans up some of the output for `iroh doctor accept` ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iroh doctor acceptandiroh doctor connectwill both run with discovery services enabled by default.Use the
--disable-discoveryflag to disable discovery.This PR also cleans up some of the output for
iroh doctor acceptChange checklist