Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iroh-cli): Make ticket-inspect print full node ids #2261

Merged
merged 5 commits into from
May 2, 2024

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented May 2, 2024

Description

feat(iroh-cli): Make ticket-inspect print full node ids

also add the option to show them in zbase32 format for pkarr interop. I need this in the workshop.

Before:

Blob ticket:
BlobTicket {
    node: NodeAddr {
        node_id: PublicKey(sq46x6htizk6222l),
        info: AddrInfo {
            relay_url: Some(
                RelayUrl(
                    "https://euw1-1.relay.iroh.network./",
                ),
            ),
            direct_addresses: {
                82.76.245.75:50824,
                192.168.1.131:50824,
                192.168.1.149:50824,
            },
        },
    },
    format: HashSeq,
    hash: Hash(
        cc4c9cd6bee4e1730447264b8290d83b3f901d88152ff0ecefb5e3050d0c500f,
    ),
}

After:

BlobTicket
  hash: zrgjzvv64tqxgbchezfyfegyhm7zahmicux7b3hpwxrqkdimkahq
  format: HashSeq
  Node Info
    node-id: sq46x6htizk6222lyz7jc4ofe3tymyw27joi3jzuhskavjczmcya
    relay-url: https://euw1-1.relay.iroh.network./
    addr: 82.76.245.75:50824
    addr: 192.168.1.131:50824
    addr: 192.168.1.149:50824

Breaking Changes

None

Notes & open questions

None

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@rklaehn rklaehn requested a review from b5 May 2, 2024 16:39
@dignifiedquire
Copy link
Contributor

dignifiedquire commented May 2, 2024

nitpick:

  • BlobTicket
  • hash
  • Node Info
  • node-id
    all have different casing, would be nice to unifiy

@rklaehn rklaehn added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit f099dab May 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants