fix(iroh-net): poll_send should drop transmits that we dont have a dest for
#2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
approved these changes
Jun 21, 2024
flub
approved these changes
Jun 21, 2024
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Jun 22, 2024
…`dest` for (n0-computer#2393) ## Description We've learned that if we return anything other than `Ok` in `poll_send`, we will be blocking the endpoint and ruining all connections. We should not return an error just because we don't have a proper address for the `dest`, instead we should log an error and wait for the connection to timeout. By returning `Poll::Ready(Ok(n))`, we are telling quinn to drop the `n` transmits that are associated with `dest`. When quinn doesn't receive any `ACK`s for those transmits, quinn end the connection with a timeout error. ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've learned that if we return anything other than
Okinpoll_send, we will be blocking the endpoint and ruining all connections. We should not return an error just because we don't have a proper address for thedest, instead we should log an error and wait for the connection to timeout. By returningPoll::Ready(Ok(n)), we are telling quinn to drop thentransmits that are associated withdest. When quinn doesn't receive anyACKs for those transmits, quinn end the connection with a timeout error.Change checklist