feat!: split relay configuration between production and staging #2425
Conversation
dignifiedquire
force-pushed
the
feat-staging-prod-relays
branch
from
b265f37
to
4e0003c
Compare
|
I am not going to do the CLI tests, they are a pain, and are about to be refactored anyway |
There was a problem hiding this comment.
Love it when I do a review and than don't hit submit...
LGTM I think, can't immediately think of something better.
The main consequence is that anyone else their test suite will also use the staging servers. That means we have to treat them as as important as the main ones. But otherwise probably the desired effect?
iroh-net/src/relay/map.rs
Outdated
| /// Use the default relay map, with production relay servers from n0. | ||
| DefaultProd, | ||
| /// Use the default relay map, with staging relay servers from n0. | ||
| DefaultStaging, |
There was a problem hiding this comment.
You have the option of calling this N0Prod and N0Staging since you're breaking the API anyway. You could also not break the API by doing Default and N0Staging or so. But this is fine as well.
There was a problem hiding this comment.
@ramfox any thoughts on which name to pick here?
There was a problem hiding this comment.
Just throwing in Default & Staging into the bikeshed. It's weird to have multiple "default".
CLI integration testsBreaking Changes
iroh_net::defaultsis now split intoprodandstagingiroh_net::RelayMode::Stagingiroh_net::discovery::dns:: N0_DNS_NODE_ORIGINis nowN0_DNS_NODE_ORIGIN_PRODand there is nowN0_DNS_NODE_ORIGIN_STAGINGCloses #2420