Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iroh)!: attempt make naming more consistent #2434

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Jul 1, 2024

Description

Attempt make naming more consistent between iroh-net endpoint, the iroh node, and the iroh client.

Breaking Changes

  • rename iroh::client::Iroh::my_relay to home_relay
  • rename iroh::client::Iroh::my_addr to node_addr
  • rename iroh::node::Node::my_relay to home_relay

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

...to be consistent with the naming in the node itself
...to be consistent with the naming in iroh-net
to be consistent with naming in iroh-net
@rklaehn rklaehn added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 6b4435d Jul 1, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants