fix(cli): Always respect the --metrics-port disabled option
#2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
--metrics-port disabledoption that works withiroh startwasn't respected when running e.g.iroh --metrics-port disabled node status.This caused CLI tests to fail when two or more commands were run concurrently due to port conflicts.
Breaking Changes
None
Notes & open questions
I think I'll try to run the tests that definitely work through CI a bit
It's... possible to test that, but technically the tests that were marked as flaky did cover this, but they weren't dedicated to the metric port option precisely. Thoughts?
Change checklist
[ ] Documentation updates following the style guide, if relevant.None needed really, just a fix.[ ] Tests if relevant.IMO we already have tests covering this (they're just marked as flaky at the moment)