Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(iroh)!: remove deprecated type aliases #2467

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Jul 5, 2024

Description

Remove type aliases for the mem and quic node types that are no longer necessary due to boxing of the rpc channel.

Also document reexports

Breaking Changes

  • iroh: remove client::MemIroh
  • iroh: remove client::QuicIroh
  • iroh: remove client::MemDoc
  • iroh: remove client::QuicDoc

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@rklaehn rklaehn marked this pull request as ready for review July 8, 2024 12:27
@rklaehn rklaehn changed the title deprecation(iroh): remove deprecated type aliases deprecation(iroh)!: remove deprecated type aliases Jul 8, 2024
@rklaehn rklaehn added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 0102b05 Jul 19, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants