fix: metrics rework & update #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
previously approved these changes
May 23, 2022
dignifiedquire
added a commit
that referenced
this pull request
Feb 20, 2023
* feat(cli): improve the output of collections * clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially completes n0-computer/beetle#270 - don't have rocks db stats yet
Gets us started on n0-computer/beetle#271
Closes n0-computer/beetle#276
Store, p2p and gateway metrics are being collected (tested manually). Bitswap registers, but no data is showing up. I don't understand bitswap enough to really know what I'm doing there.
Ideally we close out the above issues and open new ones for the remainder.