feat: Make get work on IPv6 network #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe the way deciding it's not available is not great, but it's probably good enough. I also wish rust had a "skipped" test outcome.
| @@ -53,7 +53,11 @@ async fn setup(opts: Options) -> Result<quinn::Connection> { | |||
|
|
|||
| let tls_client_config = tls::make_client_config(&keypair, opts.peer_id, opts.keylog)?; | |||
| let mut client_config = quinn::ClientConfig::new(Arc::new(tls_client_config)); | |||
| let mut endpoint = quinn::Endpoint::client("0.0.0.0:0".parse().unwrap())?; | |||
| let bind_addr = match opts.addr.is_ipv6() { | |||
There was a problem hiding this comment.
shouldn't we do this on the provide side as well?
There was a problem hiding this comment.
Actually nvm, this is only needed here.
There was a problem hiding this comment.
the provider or server endpoint already binds to whatever address you give on the commandline, so we already do. it's not like we need to call a different api for quinn, it's just that we need to have the socket bound to the same family as the server endpoint.
dignifiedquire
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.