feat(get-ticket): Contact provider on all listening addrs #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tries to contact the provider on all addresses inside the ticket when using the get-ticket command. The first connection will be used.
flub
commented
Mar 28, 2023
| opts: get::Options, | ||
| token: AuthToken, | ||
| }, | ||
| } |
There was a problem hiding this comment.
This was the simplest way to add this functionality, it's not particularly elegant or well-named though. But it works fine. If you are disgusted however and have better ideas I'm happy to try different things.
dignifiedquire
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to contact the provider on all addresses inside the ticket
when using the get-ticket command. The first connection will be used.