* fix all violations of Roslyn analyzer rules and ReSharper inspectio…

…ns @ c#/crawler
n0099 · May 10, 2024 · 3834e6b · 3834e6b
1 parent c2bf8f8
commit 3834e6b
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 6 deletions.
diff --git a/c#/crawler/src/Db/Post/BasePost.cs b/c#/crawler/src/Db/Post/BasePost.cs
@@ -1,4 +1,5 @@
 // ReSharper disable UnusedMemberInSuper.Global
+// ReSharper disable UnusedAutoPropertyAccessor.Global
 namespace tbm.Crawler.Db.Post;
 
 public abstract class BasePost : TimestampedEntity, ICloneable

diff --git a/c#/crawler/src/Db/Post/PostContent.cs b/c#/crawler/src/Db/Post/PostContent.cs
@@ -1,3 +1,4 @@
+// ReSharper disable PropertyCanBeMadeInitOnly.Global
 namespace tbm.Crawler.Db.Post;
 
 public abstract class PostContent : RowVersionedEntity

diff --git a/c#/crawler/src/Db/Revision/ForumScopedRevision.cs b/c#/crawler/src/Db/Revision/ForumScopedRevision.cs
@@ -1,3 +1,4 @@
+// ReSharper disable PropertyCanBeMadeInitOnly.Global
 namespace tbm.Crawler.Db.Revision;
 
 public abstract class ForumScopedRevision : RowVersionedEntity

diff --git a/c#/crawler/src/Db/Revision/Splitting/BaseRevisionWithSplitting.cs b/c#/crawler/src/Db/Revision/Splitting/BaseRevisionWithSplitting.cs
@@ -1,4 +1,5 @@
 // ReSharper disable UnusedMemberInSuper.Global
+// ReSharper disable PropertyCanBeMadeInitOnly.Global
 namespace tbm.Crawler.Db.Revision.Splitting;
 
 public abstract class BaseRevisionWithSplitting : RowVersionedEntity

diff --git a/c#/crawler/src/Tieba/Crawl/CrawlPost.cs b/c#/crawler/src/Tieba/Crawl/CrawlPost.cs
@@ -169,7 +169,7 @@ private Action<Exception> SaveThreadMissingFirstReply
             existingEntity.Excerpt = newEntity.Excerpt;
             existingEntity.LastSeenAt = newEntity.LastSeenAt;
         }
-        
+
         _ = db.SaveChangesForUpdate();
         transaction.Commit();
     };

diff --git a/c#/crawler/src/Tieba/Crawl/Facade/CrawlFacade.cs b/c#/crawler/src/Tieba/Crawl/Facade/CrawlFacade.cs
@@ -38,6 +38,7 @@ public virtual void Dispose()
         locks.ReleaseRange(lockId, _lockingPages);
     }
 
+    [SuppressMessage("Major Bug", "S1751:Loops with at most one iteration should be refactored")]
     public SaverChangeSet<TPost>? SaveCrawled(CancellationToken stoppingToken = default)
     {
         var db = DbContextFactory(Fid);

diff --git a/c#/crawler/src/Tieba/Crawl/Facade/ICrawlFacade.cs b/c#/crawler/src/Tieba/Crawl/Facade/ICrawlFacade.cs
@@ -3,6 +3,10 @@ namespace tbm.Crawler.Tieba.Crawl.Facade;
 public interface ICrawlFacade<TPost> : IDisposable
     where TPost : BasePost
 {
+    public delegate void ExceptionHandler(Exception ex);
+
+    public ICrawlFacade<TPost> AddExceptionHandler(ExceptionHandler handler);
+
     public SaverChangeSet<TPost>? SaveCrawled(CancellationToken stoppingToken = default);
 
     public Task<ICrawlFacade<TPost>> CrawlPageRange(
@@ -14,8 +18,4 @@ public interface ICrawlFacade<TPost> : IDisposable
         IReadOnlyList<Page> pages,
         Func<Page, FailureCount> failureCountSelector,
         CancellationToken stoppingToken = default);
-
-    public ICrawlFacade<TPost> AddExceptionHandler(ExceptionHandler handler);
-
-    public delegate void ExceptionHandler(Exception ex);
 }
diff --git a/c#/imagePipeline/src/Db/ImageMetadata.cs b/c#/imagePipeline/src/Db/ImageMetadata.cs
@@ -4,8 +4,8 @@
 // ReSharper disable UnusedMemberInSuper.Global
 using System.ComponentModel;
 using SixLabors.ImageSharp.PixelFormats;
-using Point = NetTopologySuite.Geometries.Point;
 using EntityWithImageIdAsKey = tbm.Shared.Db.EntityWithImageId.AsKey;
+using Point = NetTopologySuite.Geometries.Point;
 
 namespace tbm.ImagePipeline.Db;