Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception with defaults using Docker in Puppeteer config #48

Closed
machawk1 opened this issue Feb 1, 2019 · 2 comments · Fixed by #49
Closed

Exception with defaults using Docker in Puppeteer config #48

machawk1 opened this issue Feb 1, 2019 · 2 comments · Fixed by #49
Labels

Comments

@machawk1
Copy link
Collaborator

machawk1 commented Feb 1, 2019

Are you submitting a bug report or a feature request?

Bug report.

What is the current behavior?

Exception called with defaults using Docker and latest master (a2f1d63). I pulled the repo, changed the directory in the compose file to the working directory root (/tmp/Squidwarc), ran docker-compose build then docker-compose up.

I received the exception:

squidwarc    | Crawler Will Be Generating WARC Files Using the filenamified url
squidwarc    | A Fatal Error Occurred
squidwarc    |   TypeError: Cannot read property 'Disconnected' of undefined
squidwarc    |
squidwarc    |   - puppeteer.js:116 PuppeteerCrawler.init
squidwarc    |     /Squidwarc/lib/crawler/puppeteer.js:116:37
squidwarc    |
squidwarc    |   - next_tick.js:81 processTicksAndRejections
squidwarc    |     internal/process/next_tick.js:81:5
squidwarc    |
squidwarc    |
squidwarc    | Please Inform The Maintainer Of This Project About It. Information In package.json

What is the expected behavior?

For the crawl with the default configuration to complete.

What's your environment?

node v10.12.0 (though may be moot due to Docker), macOS 10.14.2, Squidwarc a2f1d63 (latest master), Docker 18.09.0

@machawk1 machawk1 added the bug label Feb 1, 2019
@zanderl
Copy link

zanderl commented Feb 4, 2019

I have the same issue - roughly the same configuration.

N0taN3rd added a commit that referenced this issue Feb 5, 2019
improved using squidwarc + docker fixes #44
@N0taN3rd
Copy link
Owner

N0taN3rd commented Feb 5, 2019

Reason for this issue: puppeteer did a refactoring (version bump) and Squidwarc was not aware this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants