Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dockerize build #105

Merged
merged 1 commit into from
Feb 21, 2024
Merged

ci: dockerize build #105

merged 1 commit into from
Feb 21, 2024

Conversation

ahmedalhulaibi
Copy link
Contributor

This PR codifies the build instructions in the README as a Docker image and series of scripts to emulate the GH actions workflow setup in this repo.

My main motivation was to make it easier to switch host machines and repeat a build, I did not want to have to reinstall tools each time and wanted a consistent repeatable environment.

Notes

  1. I did rename a directory because it had spaces in it and it's a nitpick of mine to use directory names with spaces in scripts - no functional reason though so lmk if you feel strongly.
  2. The .env files are derived from the YAML in the build matrix - I feel that it would be better to centralize the configs in the repo as .env and generate the build matrix inputs dynamically based on the config files. That way edits can be done in just one place. I can follow up with another PR or get that done before this is merged

feat: add esptool docker env

refactor: single reusable docker env
Copy link
Owner

@n0xa n0xa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it.

@n0xa n0xa merged commit 4caabff into n0xa:develop Feb 21, 2024
@vs4vijay
Copy link
Collaborator

Great work @ahmedalhulaibi , Is it possible to re-use these scripts / docker container / files in our Github Actions workflows? so that we only need to make changes at one place when we try to add more libraries or other changes. #JustASuggestion

@ahmedalhulaibi
Copy link
Contributor Author

@vs4vijay yeah 100% it is possible, I left a note about that in the PR description. I totally agree it would simplify things.

The .env files are derived from the YAML in the build matrix - I feel that it would be better to centralize the configs in the repo as .env and generate the build matrix inputs dynamically based on the config files. That way edits can be done in just one place. I can follow up with another PR or get that done before this is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants