Update localization.h #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Italian Language Setting
Add Italian Language
Add Italian Language but I prefer portal in english
Add Italian Language Setting
commit bc8928b Author: klamath <klamath1977@gmail.com> Date: Sun Feb 25 20:59:19 2024 +0100 Update portal.h Add Italian Language but I prefer portal in english commit 96786a3 Author: klamath <klamath1977@gmail.com> Date: Sun Feb 25 20:52:22 2024 +0100 Update localization.h Add Italian Language Setting
minor change
n0xa
requested changes
Feb 26, 2024
There was a problem hiding this comment.
I like it. Can you limit the scope of the PR to:
- Addition of Italian to localization.h
- Italian support to portal.h
- The italian define checks in portal.h and m5stick-nemo.ino (like 9 and 28 respectively)
- Wrap the wifi channel list in a language check so that it's 1-11 if LANGUAGE_EN_US is defined, and 1-14 otherwise - I do not want NEMO to break FCC laws in USA.
Also, Please base your PR against develop branch and please ensure you pick up some recently added texts such as color selection which I added to EN_US and PT_BR already.
modificato: wifispam.h
n0xa
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Italian Language Setting